Skip to content

other(tests): tests for bucketing manager#521

Merged
rebel-jinhwan merged 1 commit intodevfrom
add-bucketing-manager-tests
Apr 13, 2026
Merged

other(tests): tests for bucketing manager#521
rebel-jinhwan merged 1 commit intodevfrom
add-bucketing-manager-tests

Conversation

@huijjj
Copy link
Copy Markdown
Collaborator

@huijjj huijjj commented Apr 10, 2026

🚀 Summary of Changes

Tests for bucketing manager codes

📌 Related Issues / Tickets

  • Resolves #
  • Related to #

✅ Type of Change

  • 🚀 Release (release)
  • ✨ Feature (feature)
  • 🧠 Model support (model)
  • 🧬 Core engine changes (core)
  • 🛠 Bug fix (fix)
  • ⚙️ Performance improvement (perf)
  • 🔁 Refactor or code cleanup (refactor)
  • 📄 Documentation (docs)
  • ❓ Other (other): please describe

🧪 How to Test

  1. Run ...
  2. Verify output: ...
  3. Edge case tested: ...

📸 Screenshots / Logs (if applicable)

Before

vllm_rbln/v1/worker/bucketing/__init__.py                                             15      9      8      0    26%   43-65
vllm_rbln/v1/worker/bucketing/bucketing_manager.py                                    34     20     12      0    30%   25-32, 37, 42, 47, 52, 56-59, 73-84
vllm_rbln/v1/worker/bucketing/exponential_bucketing_manager.py                        18     14      6      0    17%   28-37, 41-53
vllm_rbln/v1/worker/bucketing/linear_bucketing_manager.py                             16     12      4      0    20%   28-37, 41-47
vllm_rbln/v1/worker/bucketing/manual_bucketing_manager.py                             11      7      2      0    31%   26-28, 34-42

After

vllm_rbln/v1/worker/bucketing/__init__.py                                             15      0      8      0   100%
vllm_rbln/v1/worker/bucketing/bucketing_manager.py                                    34      0     12      0   100%
vllm_rbln/v1/worker/bucketing/exponential_bucketing_manager.py                        18      0      6      0   100%
vllm_rbln/v1/worker/bucketing/linear_bucketing_manager.py                             16      0      4      0   100%
vllm_rbln/v1/worker/bucketing/manual_bucketing_manager.py                             11      0      2      0   100%

📋 Checklist

  • PR title follows Conventional Commits format
  • This PR is linked to an existing issue
  • The test method is described, and the expected result is clearly stated
  • Relevant documentation has been updated (if applicable)

💬 Notes

@huijjj huijjj self-assigned this Apr 10, 2026
@huijjj huijjj added the torch.compile torch.compile based implementation label Apr 10, 2026
rebel-jinhwan
rebel-jinhwan approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@rebel-jinhwan rebel-jinhwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huijjj huijjj force-pushed the add-bucketing-manager-tests branch from 57e5ba2 to f63f170 Compare April 13, 2026 01:33
@rebel-jinhwan rebel-jinhwan merged commit 226bc60 into dev Apr 13, 2026
27 of 28 checks passed
@rebel-jinhwan rebel-jinhwan deleted the add-bucketing-manager-tests branch April 13, 2026 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rebel-jinhwan rebel-jinhwan rebel-jinhwan approved these changes

@pei0033 pei0033 Awaiting requested review from pei0033

@junstar92 junstar92 Awaiting requested review from junstar92

@rebel-jiwoopark rebel-jiwoopark Awaiting requested review from rebel-jiwoopark

@rebel-sjlee rebel-sjlee Awaiting requested review from rebel-sjlee

Assignees

@huijjj huijjj

Labels

torch.compile torch.compile based implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@huijjj @rebel-jinhwan